search

zesik / react-splitter-layout

A simple split layout for React and modern browsers. https://zesik.com/react-splitter-layout
MIT License
428 stars 131 forks source link

The library doesn't work well with mini-css-extract-plugin #30

Closed julienw closed 5 years ago

julienw commented 5 years ago

Since Webpack 4 the webpack folks recommend using mini-css-extract-plugin to extract the CSS data into its own file. But this doesn't work well with this library. I think that's because the distributed version is a compiled version. I don't know if there's an easy fix for this but you may have an idea...

julienw commented 5 years ago

react-tabs exposes both a JS file and a CSS file, and a user needs to import the CSS file explicitely. I believe this would fix this issue. This would be nice but would be a breaking change.

The nice side effect is that this would allow a user to not use the default CSS -- in our project we had to override a lot of the default style.

zesik commented 5 years ago

Hi, sorry for replying late! Was having some busy months.

I'm planning to stop compiling CSS and release separated CSS file in next major release. Hopefully it can help with the problem you're facing.

zesik commented 5 years ago

This should be fixed in version 4. Please give it a try.

julienw commented 5 years ago

Thanks, we'll try and give some feedback :) In the mean time you can close this bug if you think this is fixed!