search

zesik / react-splitter-layout

A simple split layout for React and modern browsers. https://zesik.com/react-splitter-layout
MIT License
428 stars 131 forks source link

Resize secondary pane after changing secondaryPaneSize #41

Open Femax opened 5 years ago

Femax commented 5 years ago

Hi @zesik. I make resize secondary pane after changing secondaryMinSize param.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.8%) to 99.206% when pulling 2628f0404527bac81081e7521f9916ec8635e6d8 on Femax:master into e0e54194071b778d83894179622b9ae1c58b8d34 on zesik:master.

zesik commented 5 years ago

Hi @Femax,

Thanks for catching this and contributing! I have a few questions regarding this:

  1. Changing size in the render function does not reflect on internal state, nor does it trigger resize event. Could you put it somewhere so that we could keep state organized?
  2. Could you add test code for this?