zestedesavoir / django-cors-middleware

django-cors-middleware is DEPRECIATED, please use https://github.com/adamchainz/django-cors-headers instead.
Other
135 stars 34 forks source link

Start testing on Django 1.10a1 but allow failures #18

Closed edmorley closed 8 years ago

edmorley commented 8 years ago

As a precursor for supporting Django 1.10's new style of middleware, this PR:

See the individual commit messages for more details.

Another PR can then more easily iterate on adding support for the new style Django 1.10 middleware, by following: https://docs.djangoproject.com/en/1.10/topics/http/middleware/#upgrading-pre-django-1-10-style-middleware

Note: django-cors-middleware should already be compatible with Django 1.10 if used via the old-style MIDDLEWARE_CLASSES setting, it's only if users try to add it to MIDDLEWARE that they will see failures.

codecov-io commented 8 years ago

Current coverage is 94.54%

Merging #18 into master will not change coverage

@@             master        #18   diff @@
==========================================
  Files             3          3          
  Lines           110        110          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            104        104          
  Misses            6          6          
  Partials          0          0          

Powered by Codecov. Last updated by a40c20a...1cc7edd

vhf commented 8 years ago

Hey, that's really great thanks!

We'll merge it shortly. Could you please walk us through what's still to be done in order to get 1.10a1 tests to pass?

We would also really appreciate if you could follow-up on making sure this module supports Django 1.10 in the future.

ping @gustavi

edmorley commented 8 years ago

We'll merge it shortly. Could you please walk us through what's still to be done in order to get 1.10a1 tests to pass?

I've added some notes in #19 :-)

edmorley commented 8 years ago

Thank you for merging!