Closed edmorley closed 8 years ago
@@ master #18 diff @@
==========================================
Files 3 3
Lines 110 110
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 104 104
Misses 6 6
Partials 0 0
Powered by Codecov. Last updated by a40c20a...1cc7edd
Hey, that's really great thanks!
We'll merge it shortly. Could you please walk us through what's still to be done in order to get 1.10a1 tests to pass?
We would also really appreciate if you could follow-up on making sure this module supports Django 1.10 in the future.
ping @gustavi
We'll merge it shortly. Could you please walk us through what's still to be done in order to get 1.10a1 tests to pass?
I've added some notes in #19 :-)
Thank you for merging!
As a precursor for supporting Django 1.10's new style of middleware, this PR:
MIDDLEWARE
setting rather thanMIDDLEWARE_CLASSES
under Django 1.10.See the individual commit messages for more details.
Another PR can then more easily iterate on adding support for the new style Django 1.10 middleware, by following: https://docs.djangoproject.com/en/1.10/topics/http/middleware/#upgrading-pre-django-1-10-style-middleware
Note: django-cors-middleware should already be compatible with Django 1.10 if used via the old-style
MIDDLEWARE_CLASSES
setting, it's only if users try to add it toMIDDLEWARE
that they will see failures.