search

zestedesavoir / django-cors-middleware

django-cors-middleware is DEPRECIATED, please use https://github.com/adamchainz/django-cors-headers instead.
Other
135 stars 34 forks source link

Django versions #34

Closed jnayak1 closed 6 years ago

jnayak1 commented 8 years ago

Django 1.9 and 1.10 didn't work for me with this package. I switched to 1.8 and everything works great. Using:

bittner commented 6 years ago

Looks like you should switch over to django-cors-headers. All recent Django versions are now supported.

artragis commented 6 years ago

We have to rework it. We forked django-cors-headers because it we no longer maintained but its development restarted.

I will try to find out why djang0 1.9 and 1.10 do not work because in zestedesavoir-zds-site we do use django 1.10 successfuly.

Do you have more info?

bittner commented 6 years ago

@artragis I noticed that this issue is almost 16 months old. Maybe it's no longer valid.

We should add Django 2.0 to the build matrix, also update the README, and verify that the tests make sense when they actually all do pass.

In the end, though, an incomplete bug report doesn't help a lot, that is correct. Especially when the tests pass (what they do).

artragis commented 6 years ago

I'll try to take the project back