zestedesavoir / django-cors-middleware

django-cors-middleware is DEPRECIATED, please use https://github.com/adamchainz/django-cors-headers instead.

Other

135 stars 34 forks source link

Test against Django versions < 2.2 #41

Closed pieterdd closed 6 years ago

pieterdd commented 6 years ago

Updates tox.ini to target Django 1.11, 2.0 and 2.1.

artragis commented 6 years ago

Can you update Readme.md as you clearly added support.

pieterdd commented 6 years ago

I don't see them showing up in the CI yet. Hold on, making some edits.

codecov-io commented 6 years ago

Codecov Report

Merging #41 into master will increase coverage by 3.78%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   95.38%   99.17%   +3.78%     
==========================================
  Files           5        5              
  Lines         130      121       -9     
==========================================
- Hits          124      120       -4     
+ Misses          6        1       -5

Impacted Files	Coverage Δ
corsheaders/middleware.py	`98.93% <100%> (+4.76%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 863a523...923d953. Read the comment docs.

pieterdd commented 6 years ago

Updated README.md. Codecov coverage is down because test coverage is generated with Python 3.6 + Django 2.1 and the two unhit lines are - as far as I can tell - only hit by very old versions of Django. Can I remove the backwards compatibility measure to improve the coverage?

pieterdd commented 6 years ago

Removed compatibility with outdated Django versions that are no longer supported. Coverage is up now! Anything else?

artragis commented 6 years ago

Sorry for the time to answer.

THanks a lot for this PR.

adamchainz commented 5 years ago

https://github.com/ottoyiu/django-cors-headers is now maintained and tested with new Django versions. I also merged over all the features from this fork, IIRC. I'd prefer if this fork was updated to redirect users back to the original. I checked Django 2.0 and 2.1 support since they came out.