Closed StaloneLab closed 4 years ago
Now with rebase, please check but I think it is okay; I had to do a commit because some snapshots were still in their old version after the rebase.
captions now break lists (this was expected by a test, which was incorrect before);
can you explain this, And why not openning an issue that will be closed by this PR so that we can track the change?
by the way, KaTeX was updated to version 0.11.1, so please update KaTeX also on zds-site (to 0.11.1) when deploying this version of zmarkdown.
Having a look at https://github.com/KaTeX/KaTeX/releases, I see
Fix \sqrt SVG path
so @Situphen we will clearly need to update katex dependency on zds-site side
can you explain this, And why not openning an issue that will be closed by this PR so that we can track the change?
Please refer to this test. The new behaviour is expected, not a bug, but could maybe be update if it doesn't suit zds-site needs.
so @Situphen we will clearly need to update katex dependency on zds-site side
Yes.
captions now break lists (this was expected by a test, which was incorrect before);
can you explain this
This used to generate a single quote:
> Foo
> Bar
Now that it generates two quotes, this should be two quotes and their respective captions:
> Foo
Source: foo
> Bar
Source: foo
Same goes for:
> * Foo
Source: foo
> * Bar
Source: foo
Ok so everything seems to be fine for me.
This is a retake on @arobase-che's previous work on updating dependencies for zmarkdown packages.
List of changed behaviours
Here's a list of what has changed (and hence, what needs to be tested on zds-site) for reference, made by looking at the modified snapshots and fixtures:
xmlns
attribute (solves one half of #345);What remains?
First of all, I would like a global approval of the changes above by @artragis . Maybe a review is needed (poke @vhf ), but I honestly don't know how this PR could be checked, maybe by looking at the updated tests. Most importantly, it would have been great to do a rebase, but this is very complicated to do correctly here, so I think it will be a simple merge. Finally, dependencies of
remark-image-download
were NOT updated, because they would need huge refactoring of the code, and I prefer to merge this first before attempting to do it (changes are less urgent, because they don't concern security issues nor are they feature-related).