search

zestedesavoir / zmarkdown

Live demo: https://zestedesavoir.github.io/zmarkdown/
MIT License
224 stars 52 forks source link

[remark-grid-tables] Fix casing for rowspan and colspan #491

Closed mfaux closed 1 year ago

mfaux commented 1 year ago

When using remark-grid-tables as a docusaurus plugin, the following errors occur in the browser console (coming from react-dom-development.js):

Warning: Invalid DOM property `colspan`. Did you mean `colSpan`?
... (lines omitted for brevity)
Warning: Invalid DOM property `rowspan`. Did you mean `rowSpan`?

This pull request fixes the errors by changing the casings of colspan and rowspan to colSpan and rowSpan.

StaloneLab commented 1 year ago

Thanks a lot for your PR! By now, tests seem to be failing for LaTeX serialization. I will have a look soon and get back to you.

mfaux commented 1 year ago

Thanks. remark-grid-tables doesn't have package-lock.json tracked by git, so it's possible an updated dependency is causing the error.

StaloneLab commented 1 year ago

Yes, the package-lock.json is shared amongst all packages (this repository is a monorepo), that is why we do not have (it's not ignored by git, just doesn't exist) a local lock.

StaloneLab commented 1 year ago

Fixed the tests and merged, a new version will be released soon!