search

zesterer / ariadne

A fancy diagnostics & error reporting crate
https://crates.io/crates/ariadne
MIT License
1.79k stars 78 forks source link

Support labelling empty input #118

Closed ISSOtm closed 5 months ago

ISSOtm commented 6 months ago

Otherwise no labels can be printed over an empty input, not even empty ones! (get_source_groups never returns anything if there are no source lines.)

Love your crate, man! I was surprised to see how little code it contains, yet it is *super* useful. I'm switching over from codespan-reporting, and the API is much, much better! There are, however, a few issues I'd like to address before I can fully switch over.

I understand if you're not working much on this anymore, so I'd be willing to lend a hand if you'd be inclined; feel free to contact me at my commit email address if you'd prefer private communication.

Have a great day!

zesterer commented 5 months ago

Sorry it took me over a month to get round to taking a look at this, life has been busy. This change looks good, and I very much approve! I'll make sure to include this functionality in the upcoming rewrite (the ariadne2 branch).