search

zesterer / ariadne

A fancy diagnostics & error reporting crate
https://crates.io/crates/ariadne
MIT License
1.61k stars 72 forks source link

fix: `fmt::Display` for `Background<T>` should color background #36

Closed martinohmann closed 2 years ago

martinohmann commented 2 years ago

This incorrectly colored the foreground instead of the background.

martinohmann commented 2 years ago

@zesterer did you already had a chance to spend some of your valueable time reviewing this? :)

zesterer commented 2 years ago

Thanks for the PR! It seems that GitHub didn't show me notifications for this, not sure why.

martinohmann commented 2 years ago

@zesterer you could add a CODEOWNERS file to your repos so that you are automatically added to PRs as a reviewer in order to receive a notification: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

It's a little bit strange that one cannot configure this globally for ones own repos.