search

zesterer / chumsky

Write expressive, high-performance parsers with ease.
https://crates.io/crates/chumsky
MIT License
3.64k stars 155 forks source link

Update `Cargo.lock` #644

Closed samestep closed 2 months ago

samestep commented 5 months ago

As of commit ef9f20f6177b938550d0c12889c5d2dbac85558f, cloning and building the repo results in an extraneous diff on Cargo.lock, which this PR fixes.

baoyachi commented 5 months ago

Why we manage Cargo.lock file in git As a crates, there's no problem with ignore Cargo. lock

samestep commented 5 months ago

@baoyachi I thought it was pretty well-accepted that lockfiles should be committed to version control, to make local development more deterministic? https://stackoverflow.com/a/44210813/5044950

But in any case, all I'm trying to do here is fix a tiny annoyance, nothing major.

zesterer commented 5 months ago

Thanks for the PR! @baoyachi that's traditionally been the case, yes: but the Rust project has recently changed guidance in favour of committing lockfiles for libraries. I'm personally still a bit ambivalent, but it does have advantages.

zesterer commented 5 months ago

I need to fix CI at some point.

zesterer commented 2 months ago

This has since been resolved.