search

zesterer / flume

A safe and fast multi-producer, multi-consumer channel.
https://crates.io/crates/flume
Apache License 2.0
2.43k stars 84 forks source link

Implement Debug for async futures/streams #108

Open jf2048 opened 2 years ago

jf2048 commented 2 years ago

Just for completeness, these were the only things I noticed where it was missing.

zesterer commented 2 years ago

Thanks!

Edit: It seems like this PR is failing, perhaps it's better to implement Debug manually? Avoiding revealing internal implementation details would also be good, I think.

jf2048 commented 2 years ago

Whoops, I guess my rust-analyzer had a hiccup or something :)

I changed it to have Debug on those private structs, but I also can change it to just be an empty implementation of Debug for those fields/variants, would that work?

jf2048 commented 2 years ago

Now changed it to have empty implementation

zesterer commented 2 years ago

Thanks, this is ideal. It seems there is a conflict though, but this should be a trivial change.