zesterer / openmw-shaders

Photorealistic shaders for Morrowind
83 stars 7 forks source link

"Alpha Mask" Sways Independently of Opaque Foliage Texture with Wind Effect #13

Closed Professor-CDawg closed 2 years ago

Professor-CDawg commented 2 years ago

I mentioned in #12 that the foliage continued to sway after I set WIND_AMPLITUDE to 0.0. On closer inspection, I realized that at this setting, the opaque part of the foliage textures (the leaves themselves) are actually not swaying; they are stationary as they should be.

However, the "alpha mask" (I'm not sure if this is the correct term or not; I'm referring to the outline around the opaque part of the foliage textures that defines the border where transparency should end/begin) was still swaying, creating a strange visual phenomenon:

https://user-images.githubusercontent.com/68561018/176203813-e0abe00a-909f-430f-810b-feb7a16a3bd4.mp4

Notice how the "alpha mask" moves around while the actual leaves stay still in space. The "alpha mask" often overlaps the leaves, causing those portions to turn momentarily invisible. Simultaneously, the other end of the mask moves noticeably beyond the edge of the leaves, creating an obvious and animated "hole" in the mist/clouds from the Volumetric Cloud & Mist Mod.

After observing this, I tried setting WIND_AMPLITUDE back to 0.6 to see if the issue was noticeable there as well. I found that it was; while the leaves also move at this value (in addition to the "alpha mask"), they seem to do so independently of the mask, such that the two often visibly move in different directions from one another:

https://user-images.githubusercontent.com/68561018/176205268-cf1c519f-cf7b-4c21-bf8e-61145902cee7.mp4

The effect is rather visually distracting in my opinion.

zesterer commented 2 years ago

Interesting! I'll try to get some time to look into this later this week. I think the fix should be relatively trivial...

XC3N commented 2 years ago

Hello, just jumping in to confirm something, is the effect itself an issue, or this is just in the context of setting WIND_AMPLITUDE to 0.0?

I have the same effect on my side (without modifying anything) which I also find very distracting, is this working as intended?

zesterer commented 2 years ago

It's not working as intended. Rendering of the leaves happens as two passes: one for the alpha mask during shadow rendering, another to draw the foliage itself. The former doesn't seem to be correctly using the wind effect, so that needs fixing.

zesterer commented 2 years ago

@Professor-CDawg Out of interest, does this still happen with the latest commit?

XC3N commented 2 years ago

@zesterer still happening with latest commit but looks different now, before it kinda looked like a "mirror" effect, now it's got two separate shadows moving about bug .

zesterer commented 2 years ago

Could you give an overview of the shader settings you have?

XC3N commented 2 years ago

if you are referring to the config.glsl file, it's the one from the latest commit. Only change is to set preset to VANILLA.

zesterer commented 2 years ago

I mean your game settings. Alpha to coverage, etc. You should find it in your settings.cfg file.

XC3N commented 2 years ago

The only things I modified are things you suggested ;) I will link the file.

FYI, I just installed the Morrowind Optimization Patch: it makes the issue go away settings.cfg.txt .

zesterer commented 2 years ago

Ah, that's definitely interesting to note. I do most of my testing with the optimisation patch. Hopefully this is enough for me to investigate further, thanks for the details!

zesterer commented 2 years ago

@XC3N Out of interest, do I see what you have my cloud mod enabled too? Do you still observe this effect if it's disabled?

XC3N commented 2 years ago

Just performed some tests, disabled both MOP and your Cloud mod: problem is not present. Re-enabled cloud mod without MOP: problem is present Re-enabled MOP on top of cloud mod: Problem is not present

let me know if I can perform more tests for you

zesterer commented 2 years ago

@XC3N Could you confirm whether this issue was fixed in the latest commit?

XC3N commented 2 years ago

hey @zesterer, just got time to check and the issue is fixed! Good work!