search

zesterer / openmw-volumetric-clouds

A volumetric clouds mod for OpenMW
80 stars 12 forks source link

add horizon fadeout for fog effects #25

Open adQuid opened 1 year ago

adQuid commented 1 year ago

Prevents bizarre fog glow when looking off of high places past the draw distance.

(also moved some lines over a tab, which I assume wasn't intended to be double tabbed)

zesterer commented 1 year ago

Seems reasonable! Just one comment.

adQuid commented 1 year ago

Thanks for reviewing so quick, but it looks like this logic breaks down on the coastlines, so let me work on it more.

adQuid commented 1 year ago

Ok, try out this version. I ended up redoing the algorithm, but I think that this version works way better.

zesterer commented 1 year ago

Thanks. Any chance you have a screenshot showing a before/after? I'm unfortunately not in a position to check the code in-game right now.

adQuid commented 1 year ago

The first is old, second is new. I excluded clouds in those screenshots since this change doesn't affect them much. Third screenshot is after the changes with the clouds.

old new clouds

adQuid commented 1 year ago

bonus screenshot at the coast to show it still works in those conditions image