zesterer / openmw-volumetric-clouds

A volumetric clouds mod for OpenMW
80 stars 12 forks source link

Shader broken by sun changes in master #31

Closed EpochWon closed 7 months ago

EpochWon commented 7 months ago

broken

https://gitlab.com/OpenMW/openmw/-/commit/6ced0ab397347bb9d4fe8bf340ad17855dd6e214

This commit changed how the sunPos is calculated, this ends up breaking the shader because it uses the sunPos for blending. This can sort of be fixed by normalizing the sunPos, but this ends up breaking day/night transitions and the overall colour looks different.

Here is the shader in master with sunpos normalized https://github.com/zesterer/openmw-volumetric-clouds/assets/10932207/f1ff2443-f41f-43bf-a2bf-8d59523cf2c8

and what it looked like before it got broken by the commit https://github.com/zesterer/openmw-volumetric-clouds/assets/10932207/14f4efe3-e51a-4649-9319-c022c7adc3d6

zesterer commented 7 months ago

This should now be fixed.