search

zesterer / openmw-volumetric-clouds

A volumetric clouds mod for OpenMW
80 stars 12 forks source link

Add atmospheric scattering #35

Open natalieeatscats opened 5 months ago

natalieeatscats commented 5 months ago

This is the version that I like quite a bit more than my first PR, both visually and in the code, but there is a pitfal I've yet to overcome: during thunderstorms, half of the game's "visual sphere" (not sure how else to call it) furthest from the location of the sun turns completely black, and comes back only when a lightning strikes.

Screenshots of it functioning normally: screenshot016 screenshot017 screenshot014

natalieeatscats commented 5 months ago

Fixed the thunderstorm bug. Phew!

natalieeatscats commented 5 months ago

Did some optimizations and cleaned up the code quite a bit I think, also made the output more manageable (values of scattering 1.0 and mist 0.5 don't look completely whacked anymore). Some screens: screenshot018 screenshot019 screenshot020 Considering making a backup of my weather settings to make screenshots of the thing in combination with Vurt's weathers, as a point of reference

natalieeatscats commented 5 months ago

Here are the screenshots with Vurt's weather settings: screenshot021 screenshot022 screenshot023 (I might actually keep them over my own...)

zesterer commented 5 months ago

I definitely agree that Vurt's settings are an improvement here: the prior screenshots look bright purple, which I don't think is too desirable. The more configurable it is, the better, IMO. I'll try to find time to do another review tomorrow with a view toward getting this merged!

natalieeatscats commented 5 months ago

The more configurable it is, the better, IMO.

I agree, which is why I think it's better to take values from ini, which already has established presets and is easily configurable, than to hardcode them

natalieeatscats commented 5 months ago

Alright, I think I brought it to the look I am satisfied with: BaseProfile2024 04 08-13 31 48 10-ezgif com-optimize BaseProfile2024 04 08-13 31 23 09-ezgif com-optimize

natalieeatscats commented 5 months ago

Also, there is a dilemma looming over the shader: it might be more artistic if original sun color is used more, but then it is not dynamic and the quality of the look is, obviously, dependent on the color in the ini. I think it would be a great compromise to have a slider that blends between purely modified sunlight and the original sun color in the scatterring. I might even try adding that slider myself, though I'm not promising anything

natalieeatscats commented 5 months ago

Yup, added the slider! Now it is up to the user how much the sun color is modified by the scattering. Default is 0.5, which I feel is a nice balance between realism and artistry/configurability.

natalieeatscats commented 4 months ago

Anyone here? 😅

zesterer commented 4 months ago

Apologies: I've not forgotten about this, I've just been very busy with other commitments over the past few weeks. I'll try to get this reviewed over the weekend.