zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
201 stars 62 forks source link

Use list of arguments for execute_command, not a string. #246

Closed htgoebel closed 6 years ago

htgoebel commented 6 years ago

This avoids wrong quoting in arguments if one e.g. passes a double-quote in a message.

Closes #233.

htgoebel commented 6 years ago

Tests pass, ready to merge.

Thanks to the extensive test-suite, it made working out bugs a breeze.

htgoebel commented 6 years ago

Huh! What a stupid bug! Looks like this is not covered by a test-case.

reinout commented 6 years ago

Yes. That one was missing from the test case. It was easy to add, though. Fixed in the mean time.