Closed JoepGrispen closed 6 years ago
Dat is wel heel harde feedback zeg.
Email Handtekening
met vriendelijke groet,
Joep Grispen
Nelen & Schuurmans
3511 AE, Utrecht Zakkendragershof 34-44 Utrecht tel. +31 (0)30 2330 200 mob. +31 (0)6 145 86 313 www.nelen-schuurmans.nl http://www.nelen-schuurmans.nl/
Op 11/21/2017 om 12:40 PM schreef Reinout van Rees:
@reinout requested changes on this pull request.
I don't think we should merge this.
In doc/source/index.rst https://github.com/zestsoftware/zest.releaser/pull/253#discussion_r152250092:
@@ -30,3 +30,6 @@ bugs and fixing the code: developing changelog credits + +print "hello world"
This isn't valid python 3 syntax! It should be:
|print("hello world") |
And probably "hello" should be capitalized.
@mauritsvanrees https://github.com/mauritsvanrees: make sure you never start working for @JoepGrispen https://github.com/joepgrispen!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zestsoftware/zest.releaser/pull/253#pullrequestreview-78081519, or mute the thread https://github.com/notifications/unsubscribe-auth/AKqE-5j89PavPm7b0BApZxdg3Ssdzr3Jks5s4raYgaJpZM4QlrPB.
Readthedocs werkt in ieder geval als een zonnetje :-)
test how simple the process of adjusting the file is