zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

Crash when updating changelog due to incorrect encoding #256

Closed andreparames closed 6 years ago

andreparames commented 6 years ago

When running prerelease, I'm getting the same error as in #210, except the incorrect encoding comes from zest.releaser itself. I'm running it on Python 3.6.0 on a Windows machine, and the changelog is encoded as UTF-8. After the crash, the changes are left on the file, but encoded as cp1252.

The problem seems to be that zest.releaser simply ignores the encoding when writing text files on Python 3, which means the platform uses the default system encoding (obtained using locale).