search

zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

Make less-zeroes=no the default #268

Closed mauritsvanrees closed 6 years ago

mauritsvanrees commented 6 years ago

This is only used in the bumpversion command.

Current default is 'yes'. That means with a starting version of 1.2.3:

I propose to change the default to 'no'. With the same starting version of 1.2.3:

That is good for semantic versioning.

I can make the change, but I'd like to know if @reinout agrees. (And others too.)

reinout commented 6 years ago

Fine with me. Not too many people will be using the command.

Note that the documentation already mentions "no" as the default :-)

mauritsvanrees commented 6 years ago

Oopsie, I looked wrong. You are right, it is the default already. Closing. :-)

reinout commented 6 years ago

The doc says "no", but the implementation seems to say "yes". I didn't even remember this command existed, so I tried it out just now and I'm getting a number like "1.2" and not "1.2.0".

=> I think you should still change something.

reinout commented 6 years ago

Hm, default seems to be really "no", too. Apparently my head isn't made for double negatives like "less_zeroes=False"... I just can't reason effectively about this.

mauritsvanrees commented 6 years ago

Tried again, and the default indeed is 'no' and it does what I think it should do.