Closed reinout closed 5 years ago
I see a problem: the splitlines() version strips trailing newlines, something that `.split('\n') doesn't do.
So I see a diff like this:
diff --git a/setup.py b/setup.py
index 8f14dcb..57d13a6 100644
--- a/setup.py
+++ b/setup.py
@@ -5,7 +5,7 @@ from setuptools import find_packages
from setuptools import setup
-version = '6.15.5.dev0'
+version = '6.16.0.dev0'
def read(filename):
@@ -110,4 +110,4 @@ setup(name='zest.releaser',
],
},
- )
+ )
\ No newline at end of file
Yeah it works now. The diff I showed earlier was what I got out of "bumpversion" for zest.releaser itself. So bumpversion removed the newline at the end of our own setup.py and changelog. Now it works, see the version bump I just pushed :-)
Go ahead and make a release, unless you have other changes planned.
We do a
.splitlines()
inread_text_file()
now. This function usesrb
mode to get binary data in order to properly detect encodings, so there's no automatic "universal newline" behaviour. With.splitlines()
we get that behaviour back.The accompanying
write_text_file()
already uses the regularw
mode, so "universal newline" behaviour is on already there.The advantage is that it removes some dirty-looking redefinitions like this: