zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

Check if version has 'unreleased' in header #311

Closed mauritsvanrees closed 5 years ago

mauritsvanrees commented 5 years ago

When your CHANGES.rst does not have an (unreleased) version, but has for example 1.2.3 (2000-01-01) as most recent header, then pre/fullrelease will find this and happily update it to next version number you are releasing, say 1.2.4 (2019-02-15).

This can happen when your package is supposed to use towncrier but zestreleaser.towncrier is not installed. See this comment in plone.restapi.

zest.releaser can probably check if (unreleased) is missing and then either don't touch this file, or give a warning and ask for permission to continue.

mauritsvanrees commented 5 years ago

I just realized this is the more general version of issue #310. That one was about bumpversion which does the same.

reinout commented 5 years ago

So.... sounds like you smell a solution right around the corner? :-)

mauritsvanrees commented 5 years ago

I think we have covered all cases. Closing.