search

zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

Create wheel even when bdist_wheel universal is false #315

Closed mauritsvanrees closed 5 years ago

mauritsvanrees commented 5 years ago

I have enabled building universal wheels for lots of Plone packages. For a few this causes problems because for those packages the requirements are different between Python 2 and Python 3. Oops, my bad. So, @gforcada wanted to fix this by switching off universal wheels in setup.cfg like in this commit:

[bdist_wheel]
universal = 0

The side effect is that zest.releaser no longer creates wheels at all. See comment at community.plone.org. Relevant zest.releaser code is here.

I would say it is good to change zest.releaser to create a wheel even when universal is false: when there is a bdist_wheel setting, it seems logical that the developer wants a wheel, even if it should not be universal. So we can change our create_wheel method to only check that a bdist_wheel section is in the setup.cfg.

@reinout Do you agree on that?

reinout commented 5 years ago

Sounds OK. Note that I only make universal wheels, so I don't know that much of possible additional drawbacks :-)

reinout commented 5 years ago

Fixed in #316