search

zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

addchangelogentry - ValueError exception when commit messages contain % (percent symbol) #333

Closed dkopelove closed 4 years ago

dkopelove commented 5 years ago

Steps to Reproduce:

  1. pip install zest.releaser
  2. run command addchangelogentry "%"
  3. observe exception
reinout commented 4 years ago

I haven't fixed anything yet, but at least I've added a test in #334 that demonstrates that you're right :-)

reinout commented 4 years ago

Ah! The actual changelog behaviour worked fine, but the process crashed when adding the commit message. There's a "%" replacement happening in the commit message handling.

I fixed it by doing a quick % => %% replacement just for the commit message. And I tested it out on my branch, which worked :-)

reinout commented 4 years ago

See https://travis-ci.community/t/cannot-install-git-svn-apt-package/863 Travis installs a much newer git (from a PPA) than is normally present in ubuntu xenial. git-svn doesn't like that, so it is uninstallable.

reinout commented 4 years ago

@dkopelove: it should be fixed in 6.19.1! Thanks for reporting the problem :-)

dkopelove commented 4 years ago

Hi @reinout, I just tried 6.19.1 and it works for me as well. Thank you for the quick turn around.