zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

New colorama release breaks zest.releaser install on Python 3.4. #342

Closed JPTeasdale closed 1 year ago

JPTeasdale commented 4 years ago

Looks like colorama dropped support for Python 3.4 which means that pip install zest.releaser breaks on python 3.4 as well.

$ pyenv global 3.4.10
$ pip install zest.releaser
Collecting zest.releaser
Collecting colorama (from zest.releaser)
  Using cached https://pypi.uberinternal.com/packages/packages/31/cb/88c908c1be067fb6bacd3d7488ccab1a212533767b951933aac3d22648e2/colorama-0.4.2-py2.py3-none-any.whl
colorama requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.10
reinout commented 4 years ago

I guess the simplest solution is to drop support for 3.4 ourselves, too? (Or at least stop advertising that we support it and stop running the tests for it). @mauritsvanrees?

mauritsvanrees commented 4 years ago

The above error should be fixable by first doing pip install colorama with a version constraint that still works.

I am fine with dropping 3.4 support. I am not using it.

Actually:

So it seems we do not have to do anything (except maybe cleanup tox.ini).

For me personally (and the Plone community in general):

reinout commented 1 year ago

I'm closing the issue, we don't support 3.4 anymore :-)