mauritsvanrees
commented
2 years ago Hi Team, I am not sure how bumprelease feature works. Does it read "--breaking" from git log and detemines that it has to bump the release to next major release or its more like passing it via cli "bumprelease --breaking".
You pass it as option on the command line.
Theoretically we could teach it to look in your CHANGES.rst or when you use towncrier look for files like news/123.breaking, but currently this does not happen. So you should look yourself in the recent changes (optionally with the zest.releaser commands lasttaglog or lasttagdiff) and make a judgement call: should it be a breaking release, feature release, or bugfix release.
secondly. if my tags are like v1.0.1 and if I do bumprelease --version. it fails.
(base) [root@6ee061279253 legobricks]# bumpversion --breaking Checking version bump for breaking release. This is NOT a clean checkout. You are on a tag or you have local changes. Are you sure you want to continue? (y/N)? y
You are calling bumpversion from a tag. You should call it from a branch instead. We will make changes, and this needs to land in a commit on a branch.
I don't think this is what causes the problem though.
Last tag: v1.3.1 Current version: 1.3.1 Traceback (most recent call last): File "/opt/conda/bin/bumpversion", line 8, in <module> sys.exit(main()) File "/opt/conda/lib/python3.9/site-packages/zest/releaser/bumpversion.py", line 152, in main bumpversion.run() File "/opt/conda/lib/python3.9/site-packages/zest/releaser/baserelease.py", line 421, in run self.prepare() File "/opt/conda/lib/python3.9/site-packages/zest/releaser/bumpversion.py", line 60, in prepare self._grab_version(initial=True) File "/opt/conda/lib/python3.9/site-packages/zest/releaser/bumpversion.py", line 109, in _grab_version if parse_version(minimum_version) <= parse_version( File "/opt/conda/lib/python3.9/site-packages/pkg_resources/__init__.py", line 128, in parse_version return packaging.version.Version(v) File "/opt/conda/lib/python3.9/site-packages/pkg_resources/_vendor/packaging/version.py", line 274, in __init__ match = self._regex.search(version) TypeError: expected string or bytes-like object
It looks like somehow a wrong version ends up in here. We use this code to parse a version, which looks like it works both with and without a v in front:
>>> from pkg_resources import parse_version
>>> parse_version("v1.2.3")
<Version('1.2.3')>
>>> parse_version("1.2.3")
<Version('1.2.3')>It would fail when we somehow pass None:
>>> parse_version(None)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/maurits/zest.releaser/lib/python3.9/site-packages/pkg_resources/__init__.py", line 120, in parse_version
return packaging.version.Version(v)
File "/Users/maurits/zest.releaser/lib/python3.9/site-packages/pkg_resources/_vendor/packaging/version.py", line 264, in __init__
match = self._regex.search(version)
TypeError: expected string or bytes-like objectAre you familiar with pdb? Can you put a breakpoint in bumpversion.py before line 109 where it breaks, and look around?
Otherwise, tell bumpversion to print debugging info:
bumpversion --breaking --verboseWhen current tag is v1.3.1 and version is setup.py is 1.3.1.. Should bumpversion --breaking, increase it to 2.0.0 instead of failing
It should increase it to 2.0.0.
and we do tagging as v1.0.1 in our project, so what should exactly go in setup.cfg to take care of this format tag-format = v'{version}' or something else
Without the quotes. In setup.cfg:
[zest.releaser]
tag-format = v{version}But I played around a bit in a test repository, also with the v in front of the tag (which I am not used to), and could not reproduce the problem. It might depend on the version of Python and setuptools.
Oh, and the version of zest.releaser of course. Which version are you using? Latest alpha is 7.0.0a2, which I used for testing now. Latest stable is 6.22.2. Both should work though.
nishant-kumar47
Hi Team, I am not sure how bumprelease feature works. Does it read "--breaking" from git log and detemines that it has to bump the release to next major release or its more like passing it via cli "bumprelease --breaking". secondly. if my tags are like v1.0.1 and if I do bumprelease --version. it fails.
When current tag is v1.3.1 and version is setup.py is 1.3.1.. Should bumpversion --breaking, increase it to 2.0.0 instead of failing
Last tag: v1.3.1 Current version: 1.3.1
and we do tagging as v1.0.1 in our project, so what should exactly go in setup.cfg to take care of this format tag-format = v'{version}' or something else