zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

Write version in pyproject toml if available #401

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

This fixes issue #373.

mauritsvanrees commented 1 year ago

Okay, so I added a test, and it works fine. The message from the commit may be interesting: 1bd131523698c383d6974ded8c55a95355b498c6.

Problem: the test does not work on Python 3.6, so I dropped support for that. We will want to make a major release for this. And the test shows that if you only have a pyproject.toml and no setup.py at all, then fullrelease does not create and upload distributions to PyPI. So that is something that we need to fix. That is basically issue #295.

I think the current PR is fine to merge: it enables updating the version when it is in pyproject.toml. But releasing still needs a setup.py at this point, though it can be mostly empty. We could make an 8.0.0a1 release with this.

reinout commented 1 year ago

I agree. I'll merge it.