zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
199 stars 62 forks source link

Issue during our dependency-check analysis because of tests/pyproject.toml file #413

Closed LvffY closed 1 year ago

LvffY commented 1 year ago

Hello

I have been using your package for a while now and because I love living on the edge, I always used your latest releases.

Lately, we had an issue with another tool dependency-check which pointed some pyproject.toml file in your repository :

image

We solved our problem by enforcing the 7.x releases of your package with zest.releaser[recommended]<8.

I'm not sure if this is intended or not, but I'm a bit concerned about the path where this pyproject.toml is found. Is this expected that we also install the tests directory when installing the library ? I look into the the library in 7.x, and the tests directory is also included in the library

N.B: We could have a workaround by excluding this kind of file of our analysis to use the latest releases of zest.releaser.

mauritsvanrees commented 1 year ago

As Plone release manager I maintain hundreds of packages, and when they have a tests directory, I include it in the distribution. This is needed if you want to be able to run the tests for a PyPI distribution instead of a development checkout. It may be not really needed for zest.releaser, but I see nothing wrong with it.

And indeed we do not have a poetry.lock or requirements.txt in there, and that is fine.