Issues when trying 'build'

zestsoftware / zest.releaser

Python software releasing made easy and repeatable

https://zestreleaser.readthedocs.io

GNU General Public License v2.0

198 stars 62 forks source link

Issues when trying 'build' #420

Closed mauritsvanrees closed 12 months ago

mauritsvanrees commented 12 months ago

Using master here, after the merge of PR #415.

build seems to produce more warning output:

reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '*.pyc' found anywhere in distribution
...
There were errors or warnings. Are you sure you want to continue? (y/N)?

Workaround: cleanup MANIFEST.in in my test package. This is unfortunate, but I don't think we can do anything about that. cc @gforcada as we will likely see this a lot when releasing Plone packages as well.

More problematic, maybe not even related to build, is that I get this error when releasing:

ERROR: You must have a properly configured .pypirc file in your home dir to upload to a Python package index.

I very much do have this properly configured. So somehow this is not recognised. Probably an inadvertent change in the big PR from @elisallenens. I am investigating.

reinout commented 12 months ago

The *.pyc warning was what bugged @elisallenens and me in the big PR. That's where the "don't write bytecode" line in one of the test files came from.

iirc build would complain about missing *.pyc files that it is being told to ignore.

reinout commented 12 months ago

I wondered a bit whether it was an interplay between "build" and "check-manifest" that we include as a recommended tool, btw.

mauritsvanrees commented 12 months ago

Actually, we are already trying to ignore that warning. Must be slightly different here. I will see what I can do.

Apart from this problem, what has always irritated me:

You have a manifest where you say "ignore this file".
You create a distribution. This obviously does not contain the file.
You install the distribution.
setuptools/distutils/pip complains that you are ignoring a file that is not included...

But that is something that should have been solved in core Python 15 years ago already. Anyway....

reinout commented 12 months ago

Ah! Look at _project_builder_runner() in release.py. That's a function that gets passed to the "build" mechanism. The KNOWN_WARNINGS should probably be used in there.

mauritsvanrees commented 12 months ago

Yes, I already found it, and am completely replacing it. :-)

mauritsvanrees commented 12 months ago

All fixed.

mauritsvanrees commented 12 months ago

I have released 9.0.0a1.