search

zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

Check the exit code of a command, instead of relying on stderr #432

Closed mauritsvanrees closed 11 months ago

mauritsvanrees commented 11 months ago

When a command fails, always ask the user to continue or not. I hope with this we strike a good balance between showing error output, exit codes, and asking if the user wants to continue.

With the previous alpha release, the balance was not good for me. The final git push used stderr to report that everything was fine, and then postrelease treated this as an error, and asked me if I wanted to continue. Now we check the exit code.

@elisallenens @gforcada Since Reinout is unavailable for a while, can you review it, or simply try this branch out when releasing some packages? I could also do another alpha release to more easily try it.

elisalle commented 11 months ago

I tried it out with some purposefully badly configured packages; it gives errors where it should and no errors where it shouldn't, so it seems fine to me.

mauritsvanrees commented 11 months ago

Thanks for reviewing! I have released 9.0.0b1.