search

zestsoftware / zest.releaser

Python software releasing made easy and repeatable
https://zestreleaser.readthedocs.io
GNU General Public License v2.0
198 stars 62 forks source link

Using importlib instead of pkg_resources for version handling #447

Closed reinout closed 3 weeks ago

reinout commented 2 months ago

I think there's some docstring output thingy going wrong again. Perhaps the "detached HEAD" message has gotten a bit bigger in git? When comparing the output I don't really discover anything that's wrong except that the <BLANKLINE> discovery seems to discover the wrong blank lines in some cases.

@mauritsvanrees, I don't know if you're seeing something that's obviously wrong?

mauritsvanrees commented 2 months ago

I think the links about writing bdist wheel are extra.

Showing first few lines...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
...
Showing last few lines...
adding 'tha.example-0.1.dist-info/WHEEL'
adding 'tha.example-0.1.dist-info/top_level.txt'
adding 'tha.example-0.1.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
<BLANKLINE>
reinout commented 3 weeks ago

Yeah, with the test fix from @mauritsvanrees , my PR also works :-) I'm merging it.

@mauritsvanrees : I assume we can do a new release now? I merged your branch as I suspected it was ready, but for safety's sake I'm keeping my finger away from the fullrelease <enter> until you give a ping :-)

mauritsvanrees commented 3 weeks ago

Yes, a release is fine.

Greetings from the Buschenschanksprint in Austria!

reinout commented 3 weeks ago

Buschenschanksprint... Looks nice :-) Last week I passed by Innsbruck/Brennerpass (by train, of course) on my way to Napoli, so I was a little bit in the neighbourhood.

reinout commented 3 weeks ago

Release (9.2.0) done.