zestsoftware / zest.social

0 stars 0 forks source link

Configuration hard coded: Language is hardcoded to NL #1

Open toutpt opened 12 years ago

toutpt commented 12 years ago

Reading the code I found the configuration of addthis is hard coded. This as many downside:

Why not just use schemaextender to display/hide the collective.addthis viewlet ?

collective.addthis is very nice and expose all the feature of the addthis service.

mauritsvanrees commented 12 years ago

The idea is that it is easy to go to addthis.com to generate your own snippet, with all the options you want. Then use z3c.jbot to override the addthis.pt template and paste your code in there.

This might deserve a config panel, possibly just a textarea where you can simply paste this snippet.

For the ui_language option, we may want to insert plone_portal_state/language dynamically, or leave it away by default.

When I created this package, in October 2010, collective.addthis was not much more than this template yet, I think. I see it has grown since.