zesty-io / manager-ui

Content platform powering enterprise websites and applications
https://www.zesty.io
Other
41 stars 6 forks source link

Settings: Installed Fonts causes UI styles to change #182

Closed kakoga closed 4 years ago

kakoga commented 4 years ago

Describe the bug When clicking on the Settings -> Fonts -> Installed Fonts the UI styes change and do not change back until a hard-refresh is done.

To Reproduce Steps to reproduce the behavior:

  1. Open an instance with one of the following blueprints: BS Creative, Bootstrap 3.3.5, or Cat, Chameleon, Dog
  2. In that instance navigate to Settings -> Fonts
  3. Click on Installed Fonts and see settings change

Expected behavior When I install a these blueprints and click on Settings -> Fonts -> Installed Fonts I should not see any UI styling changes.

Screenshots If applicable, add screenshots to help explain your problem.

styles-break-when-bootstrap-is-in-head

Desktop (please complete the following information):

Smartphone (please complete the following information): na/

Additional context This issue only happens on instances that are using a blueprint with Bootstrap in the plate's . This doesn't happen on Material UI, Skeleton, and Blank Slate blueprints.

kakoga commented 4 years ago

@shrunyan This does affect Manager UI ! I figured out that clicking on Settings -> Styles -> Body Colors and Spacing is what triggers it - here's a loom: https://www.loom.com/share/592f249125164497bbbab8dab021a9c7

In Legacy it's triggered by Settings -> Fonts -> Installed Fonts

nibblebot commented 4 years ago

cannot reproduce this on new Manager UI using an instance with Bootstrap blueprint: https://8-d0a488cb85-8gp0kx.manager.zesty.io/settings/styles/1

@shrunyan do you have a link to an instance that can reproduce this bug?

nibblebot commented 4 years ago

@kakoga cannot reproduce this on new Manager UI, possibly after recent fixes to Settings app. Can you try the link https://8-d0a488cb85-8gp0kx.manager.zesty.io/settings/styles/1 or any other link on new Manager UI to reproduce this bug?

kakoga commented 4 years ago

@nibblebot Yeah, something else that you've fixed must have fixed this - I can no longer reproduce this in Manager UI. I'll close it.