zesty-io / manager-ui

Content platform powering enterprise websites and applications
https://www.zesty.io
Other
39 stars 5 forks source link

Content: Saved By Text is Not Appearing in the Tooltip #2394

Closed zcolah closed 5 months ago

zcolah commented 8 months ago

Describe the bug I saved a content item but when I hover over the saved text it does not show that I saved the item. It is just blank after the word "by"

CleanShot 2023-12-12 at 11 17 04

agalin920 commented 8 months ago

Additional replication steps needed

@zcolah Does your user have a name?

zcolah commented 8 months ago

@agalin920

  1. Go to https://8-f48cf3a682-7fthvk.manager.dev.zesty.io/content/6-a8bae2f4d7-rffln5/7-fc84f2b8f9-j25dz2
  2. Make a change to the content
  3. Hit Save
  4. Then Hover over the Saved Button and you will notice the user name does not appear in the tooltip

It seems like my user name does have a name btw

CleanShot 2023-12-22 at 04 51 10

agalin920 commented 7 months ago

@markelmad for https://8-f48cf3a682-7fthvk.api.dev.zesty.io/v1/env/audits?affectedZUID=7-fc84f2b8f9-j25dz2&limit=100000

Why don't we get a created nor updated audit action?

agalin920 commented 7 months ago

@markelmad Confirmed that creating a new content item does not add an 'created' audit item. Is this expected? Should a bug or feature request be added for this as this is needed to properly support desired functionality

giseleblair commented 7 months ago

@markelmad this is not expected behavior. Please file this as a bug. We should save logs on all API actions

zcolah commented 7 months ago

@giseleblair this is part of a larger conversation that needs to be had regarding the Audit Log for a content item not reflecting correctly. Will be discussing the same with Randy and Stuart today.

@giseleblair has any customer spoken up about this issue?

giseleblair commented 7 months ago

@zcolah there has not been any customer feedback on this.

zcolah commented 7 months ago

@agalin920 this issue seems to be occurring only on version 1 as we do not have a "Created" audit log. Potentially a workaround could be that we check the [created by] on the item's API and use that value as any user who creates the item is technically the user who saved the item in it's v1 state.

agalin920 commented 7 months ago

@zcolah Yea good idea. If no audit log present we can default to that.

zcolah commented 7 months ago

@giseleblair @agalin920 made an issue for it https://github.com/zesty-io/manager-ui/issues/2466

agalin920 commented 7 months ago

@markelmad any updates with this?

markelmad commented 7 months ago

@agalin920 I can also confirm the bug. Still investigating why creating an item doesn't show the user's name when hovered despite the API storing the user's ZUID in the db column action_by_user_zuid. Moreover, when updating an item, for the 'hover' to show the name, it requires an API purge (or by saving another item). I will also investigate if this can be done on the API side.

agalin920 commented 7 months ago

@markelmad the main issue it that there is no created activity record for a content item. Can you verify that?

zcolah commented 7 months ago

@agalin920 if there is no created activity record for the content item, may we take the following approach:

We check the [created by] on the item's API and use that value as any user who creates the item is technically the user who saved the item in it's v1 state.

Also we can use this as a temporary workaround if @markelmad is busy and needs more time to investigate this issue