zesty-io / manager-ui

Content platform powering enterprise websites and applications
https://www.zesty.io
Other
38 stars 5 forks source link

Content: Edit Content Item Page - Control P / Command P Shortcut to Publish Item does not work #2492

Closed zcolah closed 2 months ago

zcolah commented 5 months ago

Bug

The following two functions defined the spec of the edit content item page are not working. Please fix them.

  1. A user should be able to save and publish an item if they use Control P or Command P | Figma
  2. A user should be able to publish an item if they use Control P or Command P | Figma

Reference Articles

https://www.robin-drexler.com/2015/07/07/overriding-default-browser-shortcuts/ https://support.mozilla.org/kn/questions/1367908#:~:text=You%20can%20use%20the%20Browser,want%20to%20disable%20or%20override.

glespinosa commented 5 months ago

@zcolah I tried Ctrl+P without changing so far in the code it brings a modal isn't this the expected behavior?

https://github.com/zesty-io/manager-ui/assets/44116036/e476fe9b-51f1-4a27-95da-1146509426eb

glespinosa commented 5 months ago

@zcolah I think it's working fine also , I ask darwin to try it in their machine. Is cmd command working fine on your end?

zcolah commented 5 months ago

@glespinosa it is now working. Closing this issue.

zcolah commented 3 months ago

@glespinosa Command P is opening the print dialog. Can you look into why? CleanShot 2024-04-05 at 21 30 24

glespinosa commented 3 months ago

@zcolah Upon checking I think because you're mouse is in focus on a textfield , I don't know if this issue existed previously. Try focusing it outside the textfield

zcolah commented 3 months ago

@glespinosa Could you then add an enhancement where the Command P and Control P shortcut works even if my house is focused on a text field, or is typing in an input?

glespinosa commented 3 months ago

@zcolah upon checking again, while trying to reproduce the issue. It's now working fine.

https://github.com/zesty-io/manager-ui/assets/44116036/43e1e497-5e75-4f77-8486-c98b658ad6d6