search

zesty-io / manager-ui

Content platform powering enterprise websites and applications
https://www.zesty.io
Other
40 stars 6 forks source link

Beta Release #2729

Closed github-actions[bot] closed 3 months ago

github-actions[bot] commented 4 months ago

Created by Github action

zcolah commented 4 months ago

Publish Label

CleanShot 2024-05-31 at 17 38 41

Schedule Modal

  1. In the dropdown list, the first time zone will always be the time zone the user is in. We can detect this from their browser. If we cannot detect it, then default to Pacific Time as most users are in the United States. The second time zone will always be Coordinated Universal Time
  2. After that, please list all time zones available. This includes the time zones listed in the first section of the dropdown.

Point 2. is not being satisfied as the list of all the time zones below does not include the time zones listed in the first section of the dropdown.

finnar-bin commented 3 months ago

Resolve Spacing Issue between icon and text

@zcolah Spacing is already 8px just like what's on figma

May you please confirm that the system will default to Pacific Time as most users are in the United States. I do not know a way to test for this at the moment.

I can't figure out a way to disable my system default timezone. But I can confirm that in the code there's a fallback added like what you've requested.

zcolah commented 3 months ago

Global Notifications

@glespinosa

CleanShot 2024-06-05 at 09 12 43

zcolah commented 3 months ago

Publish Status

@finnar-bin

CleanShot 2024-06-05 at 11 24 42

zcolah commented 3 months ago

Schedule Modal

All problems fixed. @finnar-bin I have a question regarding the search of the dropdown. Please see images below.

CleanShot 2024-06-05 at 11 21 57

CleanShot 2024-06-05 at 11 22 25

finnar-bin commented 3 months ago

@zcolah you're missing a "-" that's why it's not showing.

glespinosa commented 3 months ago
  1. @zcolah is the height 44px specific only to this notification that those without heading then I can make the one with heading will have auto height? image

cause if this will be the default height in every notification, those with headings will just look like this image

  1. About the request on making bold text for those text before : it will cause an issue to other notification that came from api since some of them has : ... The design won't be consistent

Sample output for this issues: https://github.com/zesty-io/manager-ui/pull/2737

zcolah commented 3 months ago

Publish Modal

zcolah commented 3 months ago
  1. @zcolah is the height 44px specific only to this notification that those without heading then I can make the one with heading will have auto height? image

cause if this will be the default height in every notification, those with headings will just look like this image

  1. About the request on making bold text for those text before : it will cause an issue to other notification that came from api since some of them has : ... The design won't be consistent

Sample output for this issues: #2737

@glespinosa

  1. A single line notification has a height of 44px. A double line notification is 56px. How you achieve these heights from a code standpoint is up to you.

  2. Thank you raising this concern. I have revised the bold styling in the spreadsheet. See here: https://docs.google.com/spreadsheets/d/1SWff7pdgzsJsmSyIRnTz8fKRuA6KudB_1SDGUe6mOos/edit#gid=0 All you need to do now is keep the text bold until a ":" appears. After the ":" all text can be regular.

finnar-bin commented 3 months ago

Publish Modal

  1. Yeah sure I can make that happen.
  2. Looks like a recently merged theme-level change for the alert component caused this. I'll update the theme.