search

zesty-io / website

Marketing Website using NextJS and Zesty.io Headless CMS
https://www.zesty.io
The Unlicense
17 stars 2 forks source link

🐛 [Accounts]: Wrong IDP selection error will not pop-up again a second time #2168

Open shrunyan opened 10 months ago

shrunyan commented 10 months ago

Issue: If a user selects the wrong SSO IDP when loging in the flow finishes and an error pop occurs. If the user selects the wrong SSO IDP any additional times the error pop-up is no longer shown.

Expectation: The error pop-up must occur everytime a user selects the wrong IDP for the registered email

darwin808 commented 10 months ago

@agalin920

this happen both manager and website

https://github.com/zesty-io/website/assets/71545960/e66c153a-b507-4637-b587-b693ae1304f2

https://github.com/zesty-io/website/assets/71545960/075201ed-2782-406f-a8a6-9ce62836755e

mattezra commented 8 months ago

@shrunyan

This might be an issue in the login component in the material repo.

@agalin920 @theofficialnar please confirm.

finnar-bin commented 8 months ago

@mattezra after checking this out on manager-ui, the ssoError does not get cleared when the error alert message is closed. So when the same error message happens on a failed login attempt, the error alert component no longer shows up, since these lines right here won't rerun unless ssoError is either cleared or is a different value.

As for the website login, I don't know how the error is being shown/hidden though so I can't provide any input on that.

I created a bug ticket on manager-ui so it can be addressed there as well.

agalin920 commented 8 months ago

@darwin808 https://github.com/zesty-io/material/pull/84 PR is up for this