search

zestyxyz / ads-sdk

Monetize your spatial app with Zesty
https://zesty.xyz
Other
6 stars 3 forks source link

Update tests, implement refresh for other sdks #220

Closed msub2 closed 3 months ago

msub2 commented 4 months ago

This PR makes a long needed update to the SDK tests, removing tests for old styles and adding new ones for Prebid mechanisms, as well as adding tests for the react-three-fiber SDK. It also adds support for ad refreshing to the SDKs that were missing it (sans Web, which doesn't have any meaningful usage currently). Lastly, it updates the workflows for GH Actions to build the r3f and WLE test projects in CI, fixing #206.

msub2 commented 3 months ago

I think I'll actually try and make the consolidated visibility check function follow the A-Frame visibility check method. Initially I used the dot product method from Wonderland since it seemed more consistent to implement across frameworks (and it didn't involve reimplementing the three.js frustum classes and bounding box intersection calculations), but if it's localized to one function then I don't need to worry about split implementations

limbofeather commented 3 months ago

I think I'll actually try and make the consolidated visibility check function use the A-Frame visibility check also. Initially I used the dot product method from Wonderland since it seemed more consistent to implement across frameworks (and it didn't involve reimplementing the three.js frustum classes and bounding box intersection calculations), but if it's localized to one function then I don't need to worry about split implementations

Yeah this was my main thought as well - if it's in three or four different places it might be difficult to keep track of which implementation we're using if logically they're the same.