search

zet4 / alpine-tor

Just a simple rotating tor pool with haproxy load balancer. (with opt-in privoxy support)
108 stars 47 forks source link

Remove the unneeded Privoxy layer #7

Open ohaddahan opened 5 years ago

ohaddahan commented 5 years ago

Newer Tor versions support HTTPTunnelPort , making Privoxy unneeded. Can just pass --HTTPTunnelPort and connect HAProxy directly to Tor.

zet4 commented 5 years ago

Worth looking into, however due to last PR by @Otetz it might cause a regression for anyone using Privoxy's ACLs.

Leaving this open for now.

Otetz commented 5 years ago

I think not so many people use Privoxy ACL at now. The lower the points of failure — the higher the reliability. But in any case, some kind of client authorization will be required on HAProxy. In order not to leave it open to the entire Internet.

ohaddahan commented 5 years ago

@Otetz I believe Privoxy shouldn't even be in ports accessible to the outside world. Only HAProxy should, and it support authentication. I honestly don't see any use for Privoxy with the existence of HTTPTunnelPort.

zet4 commented 5 years ago

Currently I am unable to make necessary changes to this project but if someone has a spare moment they can open a PR and we can continue there.

arturhg commented 5 years ago

Probably Privoxy should be kept for a while because of this: https://tor.stackexchange.com/questions/16095/405-method-connection-mark-unattached-ap

Or DeleGate can be considered as a replacement: https://superuser.com/questions/423563/convert-http-requests-to-socks5

quite commented 5 years ago

I think it's worth noting that HttpTunnelPort only supports CONNECT. So it does not function as a transparent proxy, which many or even most clients expect when talking HTTP (for HTTPS, the connect method is indeed used). Edit: ah, this what the stackexchange link above talks about.