search

zeta-chain / example-contracts

Examples of universal smart contract implementing cross-chain swaps, NFT transfers, ERC-20 transfers and more
https://www.zetachain.com/docs
MIT License
82 stars 47 forks source link

Attempting to get a cross chain vault deposit to work #197

Closed RichJamo closed 2 months ago

RichJamo commented 2 months ago

I've been working on localnet to try and get a cross-chain deposit into a vault to work via depositAndCall The transaction is failing, but there's not much in the error message to indicate why I suspect it might be something to do with the data preparation and formatting Would love to get some more knowledgeable eyes on this to see where the problem might lie

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The changes introduce several new smart contracts, including `Mock4626`, `MockUSDC`, `VaultManager`, and `ZRC4626`, which enhance the functionality of tokenized vaults and ERC20 token management. Additionally, new Hardhat tasks for minting USDC, checking balances, and depositing tokens have been implemented. Updates to the `hardhat.config.ts` file accommodate these functionalities, reflecting improvements in the development environment for Ethereum applications. Furthermore, the `depositAndCall` task has been enhanced to improve interaction capabilities with contracts on ZetaChain. ## Changes | Files | Change Summary | |-----------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `universal/hello/contracts/...` | Introduced `Mock4626`, `MockUSDC`, `VaultManager`, and `ZRC4626` contracts for enhanced tokenized vault and ERC20 management functionalities. | | `universal/hello/hardhat.config.ts` | Updated to include new import statements for tasks related to USDC minting, balance checking, and deposits. | | `universal/hello/tasks/...` | Added various Hardhat tasks: `checkBalance`, `deploy`, `deposit`, `directDeposit`, `mintUSDC`, `evmDepositAndCall`, `evmDeposit`, `depositAndCall`, `evmCall`, and `zetachainCall` for enhanced token management and interaction with contracts. | | `universal/hello/tasks/depositAndCall.ts` | Enhanced `depositAndCall` task to improve parameter clarity, expand function capabilities, and allow dynamic gas management for transactions. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant VaultManager participant MockUSDC participant Mock4626 User->>VaultManager: depositIntoVault(amount) VaultManager->>MockUSDC: approve(amount) VaultManager->>Mock4626: deposit(amount) Mock4626-->>VaultManager: confirmation VaultManager-->>User: deposit confirmation ``` ```mermaid sequenceDiagram participant User participant MockUSDC participant VaultManager User->>MockUSDC: mint(amount) MockUSDC-->>User: confirmation User->>VaultManager: depositIntoVault(amount) VaultManager-->>User: deposit confirmation ``` ```mermaid sequenceDiagram participant User participant Receiver participant Contract User->>Receiver: depositAndCall(params) Receiver->>Contract: executeDeposit(params) Contract-->>Receiver: confirmation Receiver-->>User: deposit confirmation ``` ## Possibly related PRs - **#195**: This PR introduces tasks related to EVM interactions and updates the swap example to utilize the gateway, which is relevant to the `VaultManager` and `Mock4626` contracts in the main PR as they also deal with token management and vault functionalities.

[!TIP]

OpenAI O1 model for chat - We have deployed OpenAI's latest O1 model for chat. - OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model. - Please share any feedback with us in the [discussions post](https://discord.com/channels/1134356397673414807/1283929536186155099).
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 827d1ef606ea9c981cdec165a42118d6e60d9062 and 6667d93fde62ac0ac19c53e3e8a27e1415187c46.
Files selected for processing (1) * universal/hello/hardhat.config.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1) * universal/hello/hardhat.config.ts
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.