coderabbitai[bot]
commented
2 weeks ago 📝 Walkthrough
## Walkthrough The pull request introduces a new modifier, `onlyGateway`, across multiple smart contracts, including `Echo`, `Hello`, `Connected`, `Universal`, `Swap`, and `SwapToAnyToken`. This modifier restricts access to specific functions, ensuring that only the designated gateway address can invoke them. The `onCall` and `onRevert` functions in each contract are updated to include this modifier, enhancing security by preventing unauthorized access. Additionally, the `test.sh` script is modified to include calls to the `nft_balance` function, improving visibility of NFT balances during execution. ## Changes | File Path | Change Summary | |------------------------------------------------|----------------------------------------------------------------------------------------------------| | examples/hello/contracts/Echo.sol | - Added modifier `onlyGateway()`- Updated `onRevert` to `external onlyGateway` | | examples/hello/contracts/Hello.sol | - Added modifier `onlyGateway()`
- Updated `onCall` and `onRevert` to `external onlyGateway` | | examples/nft/contracts/Connected.sol | - Added modifier `onlyGateway()`
- Updated `onCall` and `onRevert` to `external onlyGateway` | | examples/nft/contracts/Universal.sol | - Added modifier `onlyGateway()`
- Updated `onCall` and `onRevert` to `external onlyGateway` | | examples/swap/contracts/Swap.sol | - Added modifier `onlyGateway()`
- Updated `onCall` and `onRevert` to `external onlyGateway` | | examples/swap/contracts/SwapToAnyToken.sol | - Added modifier `onlyGateway()`
- Updated `onCall` and `onRevert` to `external onlyGateway` | | examples/nft/scripts/test.sh | - Added function call `nft_balance()` at various points in the script | ## Possibly related PRs - **#186**: The `Swap` contract changes include the addition of the `onlyGateway` modifier, which is similar to the changes made in the `Echo` contract in the main PR, where the `onlyGateway` modifier was also introduced. - **#189**: The `Hello` contract in this PR also introduces the `onlyGateway` modifier and modifies the `onRevert` function, which aligns with the changes made in the `Echo` contract regarding access control. - **#192**: The `SwapToAnyToken` contract changes include the `onlyGateway` modifier, which is consistent with the access control changes made in the `Echo` contract. - **#198**: This PR modifies the `Swap` contract's approval logic, which could be related to the changes in access control and function signatures in the `Echo` contract. - **#200**: The addition of the `gatewayCall` function in the `Hello` contract demonstrates cross-chain functionality, which is relevant to the access control changes made in the `Echo` contract. - **#201**: The changes in the `Echo` contract, including the introduction of new functions and the renaming of the contract, are directly related to the modifications made in this PR, which focuses on enhancing contract functionality.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
fadeev
To prevent malicious third-party contract from calling
onCallandonRevert.Summary by CodeRabbit
New Features
onlyGateway, to enhance security across multiple contracts, ensuring that critical functions can only be executed by the designated gateway.onCall,onRevert) to include theonlyGatewaymodifier, reinforcing access restrictions.Bug Fixes
Universalcontract to revert with aTransferFailederror if gas fee transfers fail.Chores
test.shscript to include calls to display NFT balances across different blockchain networks, enhancing visibility during execution.