zeta-chain / node

ZetaChain’s blockchain node and an observer validator client
https://zetachain.com
MIT License
165 stars 105 forks source link

Create specific `IsEthereumChain` function for chains using Ethereum block header format #1272

Open lumtis opened 11 months ago

lumtis commented 11 months ago

We currently use

We currently use one of these functions to determine if we should use the EthereumProof object for header and permissionless tx verification

However:

We need a specific function that determine if a chain can use the Ethereum header format for proof @ws4charlie idea: IsCompatibleWithEthHeader

kingpinXD commented 11 months ago

This pr has a similar implementation https://github.com/zeta-chain/node/pull/1334/files#diff-19c25815bf12dd0469c0f1d7962931fb154fc029ebf203532448b0a6535335f1

lumtis commented 11 months ago

It looks like yes, although I would rename it from IsHeaderSupportedEvmChain to something like IsEthereumHeader as you could have EVM chain we could support in the future using a different header format.