search

zeta-chain / node

ZetaChain’s blockchain node and an observer validator client
https://zetachain.com
MIT License
166 stars 107 forks source link

Unknown field errors when querying pre-v19 height cosmos transactions #2835

Closed GMaiolo closed 3 weeks ago

GMaiolo commented 2 months ago

Describe the Bug When querying /cosmos/tx/v1beta1/txs?events=tx.height=4667204&page=1&limit=100&pagination.count_total=true With heights previous to the v19 update, nodes fail errors like the following

{
  "code": 2,
  "message": "codespace sdk code 2: tx parse error: errUnknownField \"*types.MsgVoteGasPrice\": {TagNum: 5, WireType:\"bytes\"}",
  "details": []
}

To Reproduce Query a pre-v19 block like /cosmos/tx/v1beta1/txs?events=tx.height=4667204&page=1&limit=100&pagination.count_total=true

Expected Behavior Transactions data should be returned successfully

GMaiolo commented 1 month ago

Another example /cosmos/tx/v1beta1/txs?events=tx.height=4687821&page=1&limit=1&pagination.count_total=true

Result

{
  "code": 2,
  "message": "codespace sdk code 2: tx parse error: unable to resolve type URL /zetachain.zetacore.crosschain.MsgVoteOnObservedInboundTx",
  "details": []
}
kingpinXD commented 1 month ago

Both the example contain proto buffers which have been modified

GMaiolo commented 1 month ago

@kingpinXD would this impact someone that tries to create an indexer for ZetaChain from genesis?

kingpinXD commented 1 month ago

This would impact someone trying to sync from block 1 , if they use the current binary and try to fetch older transactions

kingpinXD commented 1 month ago

v21 modifies the UpdateChainInfo message , and is a breaking change We should verify on athens 3 , that we do not run into a similar issues as this https://github.com/zeta-chain/node/pull/2890

GMaiolo commented 3 weeks ago

@lumtis does this need an update on the nodes?