Closed lumtis closed 1 month ago
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 0%
with 84 lines
in your changes missing coverage. Please review.
Project coverage is 65.80%. Comparing base (
404bd96
) to head (d919a0f
). Report is 5 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
x/crosschain/types/legacy_msgs.go | 0.00% | 84 Missing :warning: |
@kingpinXD & @lumtis,
I've set up a basic Athens full node from a v19 snapshot, and ran it to the v20 upgrade. At the v20 upgrade height, I used a binary built from https://github.com/zeta-chain/node/tree/v20-restore-old-messages. That branch was based on release/v20
and I cherry picked in the commits from https://github.com/zeta-chain/node/pull/2909.
The v20 flavor of the binary I produced runs, though the node only has blocks from 6711001 onward, which is after the v19 upgrade and presumably is missing knowledge of the blocks which contains the messages we need to test.
If needed, we can run this v20 binary with a copy of an archive node's data.
Were there any messages present in v19 but not v20 that could be used to test?
@kingpinXD & @lumtis,
I've set up a basic Athens full node from a v19 snapshot, and ran it to the v20 upgrade. At the v20 upgrade height, I used a binary built from https://github.com/zeta-chain/node/tree/v20-restore-old-messages. That branch was based on
release/v20
and I cherry picked in the commits from #2909.The v20 flavor of the binary I produced runs, though the node only has blocks from 6711001 onward, which is after the v19 upgrade and presumably is missing knowledge of the blocks which contains the messages we need to test.
If needed, we can run this v20 binary with a copy of an archive node's data.
Were there any messages present in v19 but not v20 that could be used to test?
The test would be the same as on the initial issue https://github.com/zeta-chain/node/issues/2835
This PR should solve the error encountered during the query but it is on mainnnet.
If needed I can look into having an example to test with Athens3
The same query provided in the issue also fails when pointed at an Athens testnet archive node. It returns this response:
{"code":2,"message":"codespace sdk code 2: tx parse error: unable to resolve type URL /zetachain.zetacore.crosschain.MsgGasPriceVoter","details":[]}
This does seem to fix MsgVoteGasPrice
(looked at block 6325419
right before the v19 upgrade on Athens) but MsgGasPriceVoter
from block 4667204
does not work. I would expect the same to be true for Mainnet blocks created on a pre-v16 network.
This does seem to fix
MsgVoteGasPrice
(looked at block6325419
right before the v19 upgrade on Athens) butMsgGasPriceVoter
from block4667204
does not work. I would expect the same to be true for Mainnet blocks created on a pre-v16 network.
Ok, wanted to check with the initial query of the issue first. MsgGasPriceVoter
was also missing, added it here, if we can check again the query with the new version of the binary would be great!
I checked the previous breaking changes, we should not have other message used frequently that should have this compatibility issue
@skosito @fbac please check back
Description
VoteGasPrice
back in the messageCloses: https://github.com/zeta-chain/node/issues/2835
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation