chore: improve localnet build performance

[gartnera]

Description

• Don't use a timestamp if dirty build. Doing this forced unconditional rebuilds every run.
• Don't copy the git directory into the build. This requires that we also provide a way to push the version info into the build.

With this change you should be able to run make start-e2e-test and if nothing has changed zetanode should not be rebuilt.

I could also be convinced that the localnet build should always just be static. Like v22.0.0-next or something like that.

Summary by CodeRabbit

• New Features

  • Enhanced versioning logic in the version.sh script, providing more detailed version information including short commit hashes.

• Improvements

  • Docker build process optimized with new arguments for version control.
  • Streamlined handling of legacy versions in Dockerfile.

• Bug Fixes

  • Adjusted output format for versioning in version.sh to include commit details for both dirty and non-dirty builds.

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

📝 Walkthrough

📝 Walkthrough

## Walkthrough The pull request introduces significant modifications across several files, primarily focusing on the Docker and Makefile configurations. Key changes include the introduction of new versioning arguments (`NODE_VERSION`, `NODE_COMMIT`, `OLD_VERSION`, and `BUILDARCH`) in the Dockerfile, updates to the Makefile for tracking these new variables, and enhancements to the versioning logic in the `version.sh` script. The `.dockerignore` file has also been adjusted to improve the build process by ignoring unnecessary files and directories. ## Changes | Files | Change Summary | |---------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `.dockerignore` | Added `.git` to ignore list; removed `localnet`, `package.json`, `yarn.lock`, `.github/`, `.gitignore`, and `dist/**`; excluded Dockerfile entries from ignore list. | | `Dockerfile-localnet` | Introduced `NODE_VERSION`, `NODE_COMMIT`, `OLD_VERSION`, and `BUILDARCH` arguments; organized build stages for modularity; included legacy build options. | | `Makefile` | Replaced `VERSION` and `COMMIT` with `NODE_VERSION` and `NODE_COMMIT`; updated `ldflags` to reflect new variables; modified `zetanode` target for Docker build args. | | `version.sh` | Added conditional check for `NODE_VERSION`; modified output format for version strings to include short commit hash; improved logic for dirty and non-dirty builds. | ## Possibly related PRs - #2689: The changes in the `Makefile` to update the `OLD_VERSION` argument to `NODE_VERSION` and `NODE_COMMIT` are directly related to the modifications made in the main PR, which also introduced these new arguments in the Dockerfile and Makefile. ## Suggested labels `UPGRADE_IMPORT_MAINNET_TESTS` ## Suggested reviewers - lumtis - skosito - kingpinXD - brewmaster012 - fbac - swift1337

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.