search

zeta-chain / node

ZetaChain’s blockchain node and an observer validator client
https://zetachain.com
MIT License
164 stars 105 forks source link

`zetacore` : Register interfaces #3003

Open kingpinXD opened 5 days ago

kingpinXD commented 5 days ago

Check if we need to register interfaces twice

We manually register them here https://github.com/zeta-chain/node/blob/404bd9625da63d958daa185839fc2fe5d1d93475/app/encoding.go#L31-L48

But they also registered the get with cosmos SDK in the makeconfig call.

lumtis commented 5 days ago

We manually register them here https://github.com/zeta-chain/zeta-node/blob/c8c833f66e3862cfa9e12c357436322e4f12c807/app/encoding.go#L32-L49

This link doesn't return to an existing code

Why is it needed to register the interface twice?

kingpinXD commented 5 days ago

I dont think we do , noticed that it was being done twice while working on a pr , will investigate and remove in a future task