Closed lumtis closed 2 weeks ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
🗂️ Base branches to auto review (1)
* developPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 0%
with 13 lines
in your changes missing coverage. Please review.
Project coverage is 65.94%. Comparing base (
7e0a192
) to head (8a324de
). Report is 1 commits behind head on release/v20.
Files with missing lines | Patch % | Lines |
---|---|---|
zetaclient/chains/bitcoin/signer/signer.go | 0.00% | 12 Missing :warning: |
zetaclient/chains/bitcoin/observer/outbound.go | 0.00% | 1 Missing :warning: |
LGTM
Description
Check if the amount for a BTC revert outbound is below dust amount. In this case, cancel the tx (same logic as restricted address where there will be a tx but with 0 btc), cctx will be reverted.
Add a E2E test to test revert with dust amount. To check the effect, the "dustAmount" can be set to false in ZetaClient, the test will be stall because the outbound can't be signed