search

zeta-chain / node

ZetaChain’s blockchain node and an observer validator client
https://zetachain.com
MIT License
167 stars 109 forks source link

fix(zetaclient): lock pingRTT for writing #3181

Closed gartnera closed 1 week ago

gartnera commented 1 week ago 
fatal error: concurrent map writes

goroutine 180835 [running]:
main.start.func4.1({0x4000ff8600, 0x27})
    /go/src/github.com/zeta-chain/node/cmd/zetaclientd/start.go:258 +0x17c
created by main.start.func4 in goroutine 872
    /go/src/github.com/zeta-chain/node/cmd/zetaclientd/start.go:248 +0xb8

Closes https://github.com/zeta-chain/node/issues/3180. Will backport to v22.

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago
📝 Walkthrough ## Walkthrough The changes in this pull request enhance the `Start` function in `cmd/zetaclientd/start.go` by introducing a mutex lock for thread-safe access to the `pingRTT` map, which tracks round-trip times for ping operations. The pinging logic for whitelisted peers is now executed in a goroutine with improved error handling and logging. Each ping operation has a timeout, and errors are logged with more context. These modifications aim to prevent concurrent map write errors and improve overall application robustness. ## Changes | File Path | Change Summary | |----------------------------------|-----------------------------------------------------------------------------------------------------| | cmd/zetaclientd/start.go | Added `pingRTTLock` mutex for thread-safe access to `pingRTT` map; improved pinging logic in goroutine; enhanced error handling and logging. | ## Assessment against linked issues | Objective | Addressed | Explanation | |----------------------------------------------------|-----------|-------------------------------------------------| | Prevent concurrent map writes (Issue #3180) | ✅ | | ## Possibly related PRs - #2882: This PR enhances error handling in the `BlockByNumber` method, similar to the improved error handling in the `Start` function of the main PR, both focusing on preventing runtime errors and improving robustness. - #2881: Although primarily focused on panic logging, it shares a common theme of enhancing error handling, which aligns with the improvements made in the main PR's error management. ## Suggested reviewers - lumtis - fbac - kingpinXD - ws4charlie - swift1337 - skosito - brewmaster012

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.