zeta-chain / node

ZetaChain’s blockchain node and an observer validator client
https://zetachain.com
MIT License
167 stars 109 forks source link

chore: upgrade bitcoin-core to 28.0 #3191

Closed gartnera closed 3 days ago

gartnera commented 5 days ago

Upgrade to bitcoin-core 28.0

This requires four things:

We need to upgrade to bitcoin-core 28.0 for testnet4 support. Related to https://github.com/zeta-chain/node/issues/2242

Summary by CodeRabbit

coderabbitai[bot] commented 5 days ago

[!IMPORTANT]

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces significant modifications to the `docker-compose.yml` file, including updates to the `bitcoin` service image and the addition of new services such as `eth2`, `upgrade-host`, and `upgrade-orchestrator`. The `orchestrator` service now has a dependency on the `eth` service. Additionally, the `setup_bitcoin.go` file has been updated to simplify the `SetupBtcAddress` method by removing an unnecessary parameter and enhancing error handling during wallet creation. ## Changes | File Path | Change Summary | |-----------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------| | contrib/localnet/docker-compose.yml | - Updated `bitcoin` service image from `ghcr.io/zeta-chain/ruimarinho-bitcoin-core:22` to `ghcr.io/zeta-chain/bitcoin-core-docker:27.2`
- Added command `-deprecatedrpc=create_bdb` to `bitcoin` service
- Introduced `eth2` service with build context `./anvil`
- Added `upgrade-host` and `upgrade-orchestrator` services with profiles
- Updated `orchestrator` service to depend on `eth` service | | e2e/runner/setup_bitcoin.go | - Modified `SetupBtcAddress` method signature by removing `name` parameter
- Added JSON request construction for wallet creation with error handling
- Other methods largely unchanged but maintain existing logic and logging | ## Possibly related PRs - **#2911**: This PR adds static chain information for Bitcoin Testnet4, which is relevant to the changes in the main PR that involve the Bitcoin service configuration in the Docker Compose file. - **#2989**: This PR focuses on using a prebuilt bitcoin-node-sidecar, which relates to the updates in the Docker Compose file for the Bitcoin service in the main PR. - **#3037**: This PR ensures that the Docker Compose file is always explicitly set, which connects to the modifications made in the main PR regarding the Docker Compose setup. - **#3063**: This PR establishes version 21 as the new upgrade base, which may relate to the overall service configuration and dependencies in the Docker Compose file of the main PR. - **#3067**: This PR adjusts governance parameters for localnet, which could indirectly relate to the service configurations and dependencies in the main PR's Docker Compose file. ## Suggested labels `UPGRADE_TESTS`, `UPGRADE_IMPORT_MAINNET_TESTS` ## Suggested reviewers - fbac - kingpinXD - swift1337 - skosito - ws4charlie - lumtis - brewmaster012

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.