Closed CharlieMc0 closed 5 months ago
thanks @CharlieMc0
5th/6th will be fixed in athens3
3rd/4th not sure; they are needed by zetaclients but perhaps not by third party apps or services. Maybe blockpi can disable them.
2nd: @aldapp7 any comment?
1st: @fadeev @kingpinXD may be able to comment.
2nd, not sure, never tested that and it wasn't in the scope on updating Ethermint rpcs, I will take a look.
1st: I believe the params module has been deprecated.
1st: I believe the params module has been deprecated.
Sounds good. I imagine that your PR on OpenAPI generation remove this endpoint?
That PR was focused on serving existing OpenAPI spec. If we merge the buf
PR, I can add buf-based OpenAPI spec generation that will remove this endpoint (and just provide more reliable spec generation process).
@brewmaster012 @CharlieMc0 2nd unlikely be able to fix, issue goes deep into ethermint x/types, which we obviously don't want to fork and tweak to our own (too large to support it just for this rpc), fails here https://github.com/zeta-chain/zeta-node/blob/develop/rpc/backend/tracing.go#L115 -> uses evmtypes.QueryClient https://github.com/zeta-chain/zeta-node/blob/develop/rpc/types/query_client.go#L38 which is imported from https://github.com/zeta-chain/zeta-node/blob/develop/rpc/types/query_client.go#L28
Closing as it seems no longer relevant with the current state of the project. Feel free to reopen it.
These RPC methods either don't work or can cause the node to lock up and/or crash when used.
Reported by BlockPi