HAL 01: Zeta supply does not track assets correctly

zeta-chain / node

ZetaChain’s blockchain node and an observer validator client

https://zetachain.com

MIT License

167 stars 108 forks source link

HAL 01: Zeta supply does not track assets correctly #564

Open fadeev opened 1 year ago

fadeev commented 1 year ago

### Tasks
- [ ] https://github.com/zeta-chain/node/issues/1352
- [ ] https://github.com/zeta-chain/node/issues/1353
- [ ] https://github.com/zeta-chain/node/issues/1354
- [ ] https://github.com/zeta-chain/node/issues/1355

lumtis commented 1 year ago

@kingpinXD can we break down into several tasks?

CharlieMc0 commented 1 month ago

Is this completed? @lumtis @kingpinXD ?

kingpinXD commented 1 month ago

No, it's not The supply checker initially implemented was disabled as we planned to test it on Athens to determine the frequency of these checks so that the notifications are helpful.

This would need to be prioritised / revisited to enable it backup again . Based on the current codebase , we would need to refactor the checking function

lumtis commented 4 weeks ago

We decided to go with monitoring + using emergency proposals

The previous ZetaClient implementation was bloated since requiring new queries and unclear process to report accounting issues. There is no reason for ZetaClient to be in charge of this if emergency proposals are executed by external parties

What we should do is refactor to use a lock/unlock model for ZETA instead of mint/burn for non-Ethereum chians but we should first decide if we want to transition ZETA to the contract v2 model